Only call 3dslink if a runner is not configured #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help catch dead code more easily, since completely pub fns are never considered to be unused but pub(crate) fns may be.
ian-h-chamberlain
force-pushed
the
fix/dont-always-link
branch
from
6b23e1e
to
e3d83cd
Compare
Meziu
approved these changes
Jun 19, 2024
Yeah, I couldn't think of a better way to try and catch more dead code (like the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #60 which I believe broke
cargo testandcargo runwhen a custom runner is configured...#49 would probably have caught this if we ran some tests in CI — I will see if it's not too hard to add some kind of dummy crate to test against for those cases (integration tests, examples etc.)